Skip to content

Make kube-scheduler Service return errors for healthcheck#584

Merged
mangelajo merged 1 commit into
openshift:mainfrom
mangelajo:kube-scheduler-return-error
Feb 3, 2022
Merged

Make kube-scheduler Service return errors for healthcheck#584
mangelajo merged 1 commit into
openshift:mainfrom
mangelajo:kube-scheduler-return-error

Conversation

@mangelajo

@mangelajo mangelajo commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Miguel Angel Ajo majopela@redhat.com

@mangelajo
Make kube-scheduler Service return errors for healthcheck
990b166 
Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
@openshift-ci openshift-ci Bot requested review from cooktheryan and oglok January 27, 2022 17:25
@mangelajo mangelajo requested a review from fzdarsky January 27, 2022 17:26
@fzdarsky

fzdarsky commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzdarsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 28, 2022
@fzdarsky fzdarsky removed the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022
@fzdarsky

fzdarsky commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

See #585. Need to either panic on error here or globally.

@copejon

copejon commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci

openshift-ci Bot commented Jan 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@mangelajo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-arch 990b166 link false /test e2e-openshift-conformance-sig-arch

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mangelajo

mangelajo commented Feb 2, 2022

Copy link
Copy Markdown
Contributor Author

/retest

@mangelajo

mangelajo commented Feb 2, 2022

Copy link
Copy Markdown
Contributor Author

See #585. Need to either panic on error here or globally.

Just noticed that returning an error instead of panicing means the ServiceManager just logs the service as stopped (with error) but MicroShift continues running in an undefined state. Need to either panic on error here or globally.

Not after #575 , I think it's ok now to move back to LGTM :-)

@mangelajo mangelajo merged commit 497cb6b into openshift:main Feb 3, 2022
@mangelajo mangelajo mentioned this pull request Mar 4, 2022
Open
@mangelajo mangelajo mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cooktheryan cooktheryan Awaiting requested review from cooktheryan

@oglok oglok Awaiting requested review from oglok

@fzdarsky fzdarsky Awaiting requested review from fzdarsky

Assignees

@fzdarsky fzdarsky

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mangelajo @fzdarsky @copejon